rust-lang / rust-lang/rust-clippy
unecessary cast false positive
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Summary
This code will fail to compile:
fn main() {
let n: f64 = 1.0;
let _: f64 = (0.05).min(n);
}
making a cast necessary (or preferable to 0.05f64 IMO).
Writing this code, will compile, but causes clippy to warn:
fn main() {
let n: f64 = 1.0;
let _: f64 = (0.05 as f64).min(n);
}
I suspect it might be really difficult to solve this in a non-hacky way, but thought I would create this issue to at least raise awareness.
Lint Name
unecessary cast
Reproducer
No response
Version
rust playground stable 1.83.0: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=115441b5376a81c65d1cd21c2d86ac6d
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Start by reproducing the example in the linked Rust Playground and tracing the unnecessary-cast lint named in the issue; done means the required cast no longer triggers a false positive while genuinely unnecessary casts remain diagnosed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100