rust-lang / rust-lang/rust-clippy

manual_unsigned_abs

Open
#13,786 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Replace -{signed} as {unsigned} with {signed}.unsigned_abs()

Advantage

Clear and concise meaning & order of operations.
No panics or overflow (potentially).

Drawbacks

No response

Example
let n: isize = -42;
-n as usize

Could be written as:

let n: isize = -42;
n.unsigned_abs()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation file or test is named. Start by reviewing rust-lang/rust-clippy's existing lint patterns for signed-to-unsigned casts; done means the requested unsigned_abs() replacement is covered by appropriate lint behavior and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.