rust-lang / rust-lang/rust-clippy
clippy-internal lint suggestions
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
During the current rustup I noticed several inconsistencies in our lints. I think the following would be good defaults that make working with these lints easier due to a consistent style
- if a type contains a
&LateContextor&EarlyContextrequire the struct to not be a tuple struct and the field namedcx - All
Visitors' lifetime must be called'tcx
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing clippy-internal lints and their tests, then compare how context-containing types and Visitor lifetimes are currently represented. Done means the two proposed naming and struct-shape conventions are consistently enforced, with tests covering the resulting diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100