rust-lang / rust-lang/rust-clippy
Lint generic methods using Into/AsRef/AsMut above very modest complexity
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Due to the fact that the compiler has to monomorphize the function, it's advisable to create a wrapper function that does the .as_ref()/.as_mut()/.into() calls and then calls the inner function. That way the monomorphization pass only has to generate one call per instantiated method.
This can be done by first checking methods for generics and if any are detected call the ComplexityVisitor with a severely reduced threshold. We probably need to noodle around a bit to find the correct number here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ComplexityVisitor and the code that checks whether methods are generic. Experiment with a substantially reduced complexity threshold for methods using Into, AsRef, or AsMut, and determine the appropriate value. Done means generic methods are linted with the reduced threshold while non-generic methods retain existing behavior, with coverage for the new cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100