rust-lang / rust-lang/rust-clippy
Use `sin_cos`
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Suggests usage of f32::sin_cos and f64::sin_cos where it would be more optimal than calling sin and cos individually.
Advantage
sin_cos could have optimizations (although it doesn't seem to at the moment)
sin_cos supposedly exists to be more readable
Drawbacks
No response
Example
Should detect:
let sin_theta = sin(theta);
let cos_theta = cos(theta);
And suggest:
let (sin_theta, cos_theta) = sin_cos(theta);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Clippy lint implementation and tests for detecting paired sin and cos calls on f32 or f64. Use the issue's Rust example as the target case, and consider the work complete when the pair produces the requested sin_cos suggestion with appropriate coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100