rust-lang / rust-lang/rust-clippy

`iter.map(...).any(identity)` into `iter.any(...)`

Open
#13,267 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Make the code more concise

Advantage
  • Less code
  • simple
Drawbacks

No response

Example
pub fn foo<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .map(|s| s.is_empty())
        .any(|i| i)
}
pub fn bar<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .map(|s| s.is_empty())
        .any(core::convert::identity)
}
pub fn baz<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .map(|s| s.is_empty())
        .all(core::convert::identity)
}

Could be written as:

pub fn foo<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .any(|s| s.is_empty())
}
pub fn bar<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .any(|s| s.is_empty())
}
pub fn baz<'a, T: AsRef<str> + 'a>(iter: impl Iterator<Item = &'a T>) -> bool {
    iter.map(AsRef::as_ref)
        .all(|s| s.is_empty())
}

Iterator::any and Iterator::all

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's Rust examples and the documentation for Iterator::any and Iterator::all. Identify the existing Clippy lint and test locations for iterator simplifications, then check how equivalent identity closures are represented. Done means the proposed redundant mapping and predicate forms are recognized with appropriate tests and diagnostics.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.