rust-lang / rust-lang/rust-clippy
Don't fire items_after_statements when the statement isn't used before its declaration
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Summary
I'm finding that items_after_statements makes my code more confusing by forcing me to put inner structs way before they are used (I do this often as a one-time thing to clarify a tuple). I believe it would make more sense to only fire this lint if the struct/function is actually used before it is declared.
Lint Name
items_after_statements
Reproducer
No response
Version
No response
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation and tests for the items_after_statements lint. Read how declaration use-before-declaration is detected, then add coverage for declarations used only after their declaration; done means the lint no longer reports those cases while preserving its existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100