rust-lang / rust-lang/rust-clippy

Lint suggestion: duplicate or redundant trait bounds

Open
#12,919 2 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Checks for traits that are bounded by the same trait more than once.

If you want to get fancy with it, you could add a check for implied duplicate bounds, e.g. Hash implies PartialEq, so trait Foo: Hash + PartialEq is pointless.

This was detected in https://github.com/Leafwing-Studios/leafwing-input-manager/pull/545.

Playground link: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e298f6d998b87fe37663e1df073297f4

Advantage

These duplicate bounds are pointless and confusing.

Drawbacks

The more advanced implied redundant trait bound detection could reduce clarity of the code, and is less robust to future refactoring of the traits being relied on, as bounds may be removed in the future.

Example
use core::fmt::Debug;

trait SuperDebug: Debug + Debug + Debug { }

Could be written as:

use core::fmt::Debug;

trait SuperDebug: Debug { }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Rust Playground example and the duplicate-bound case described in the issue, then inspect rust-clippy's existing lint implementations and tests to find the appropriate entry point. Done means detecting repeated trait bounds with clear diagnostics; implied bounds such as Hash and PartialEq are optional and should be evaluated separately.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.