rust-lang / rust-lang/rust-clippy

Lint for trailing comma in macro parameters

Open
#12,814 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

This proposed lint would detect and warn about unnecessary trailing commas in macro parameters. While a trailing comma in macro parameters is not an error in Rust, it can be superfluous and might not align with some coding style preferences.

Advantage
  • Improved Readability: Removing unnecessary trailing commas can make the code clearer and easier to read.
  • Consistency: Enforcing this style can help maintain a consistent coding standard across the codebase.
Drawbacks

No response

Example
println!("Hello, world!", );

Could be written as:

println!("Hello, world!");

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation file, test, or entry point is named in the issue. Start by locating existing Rust Clippy lints for macro invocation style, then compare their tests and configuration; done means the lint detects the unnecessary trailing comma shown in the example without treating valid macro syntax as an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.