rust-lang / rust-lang/rust-clippy

"if not this separator or not that separator" misunderstanding

Open
#12,633 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

lint for if condition (for multiple conditions that start by !) and path separator

Advantage

No response

Drawbacks

No response

Example
use std::{io::*, path::*};
fn main() {
    let mut s = String::new();
    stdin().read_line(&mut s).unwrap();
    if !s.ends_with('/') || !s.ends_with('\\') {
        panic!("Path must end by / or \\")
    }
    let p = Path::new(&s);
}

There's a misunderstanding in the if condition, someone may read if !s.ends_with('/') || !s.ends_with('\\') as "if not this separator or not that separator", and there's a constant MAIN_SEPARATOR in std::path, the better code may be:

use std::{io::*, path::*};
fn main() {
    let mut s = String::new();
    stdin().read_line(&mut s).unwrap();
    if !s.ends_with(MAIN_SEPARATOR) {
        panic!("Path must end by {MAIN_SEPARATOR}")
    }
    let p = Path::new(&s);
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names Rust examples and std::path::MAIN_SEPARATOR, but no source file or test is provided. Start by clarifying the intended lint behavior for the two negated ends_with checks and the platform separator. Done means the accepted condition is unambiguous and the behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.