rust-lang / rust-lang/rust-clippy
arc_with_non_send_sync could indicate why inner type needs to become Send + Sync
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
warning: usage of an `Arc` that is not `Send` and `Sync`
= note: `Arc<NiepceApplication>` is not `Send` and `Sync` as:
= note: - the trait `Send` is not implemented for `NiepceApplication`
= note: - the trait `Sync` is not implemented for `NiepceApplication`
= help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
= note: if you intend to use `Arc` with `Send` and `Sync` traits
= note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `NiepceApplication`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
The suggestion of using Rc is unhelpful because the intent is really to have Arc.
What would be great is diagnostic info telling me why it isn't Send + Sync by recursively telling me which inner type isn't, and why.
Version
rustc 1.77.1 (7cf61ebde 2024-03-27)
binary: rustc
commit-hash: 7cf61ebde7b22796c69757901dd346d0fe70bd97
commit-date: 2024-03-27
host: x86_64-unknown-linux-gnu
release: 1.77.1
LLVM version: 17.0.6
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the arc_with_non_send_sync lint and inspect how its current diagnostic is produced. Determine how recursive Send and Sync explanations could be represented, then add coverage showing the diagnostic identifies the inner non-Send or non-Sync type and why it fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100