rust-lang / rust-lang/rust-clippy

single_elem_arr

Open
#12,191 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Checks for arrays with single elements.

Advantage
  • Reduces type complexity.
Drawbacks

No response

Example
fn main() {
    let mut a = [15u8];
    takes_slice(&a);
    takes_mut_slice(&mut a);
}
fn takes_slice(_: &[u8]) { todo!() }
fn takes_mut_slice(_: &mut [u8]) { todo!() }

Could be written as:

use std::slice::{from_ref, from_mut};
fn main() {
    let mut a = 15u8;
    takes_slice(from_ref(&a));
    takes_mut_slice(from_mut(&mut a));
}
fn takes_slice(_: &[u8]) { todo!() }
fn takes_mut_slice(_: &mut [u8]) { todo!() }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name implementation files or tests. Start by reviewing the two Rust examples and determine the cases the proposed lint should recognize, including immutable and mutable slice conversions. Done means the lint identifies unnecessary single-element arrays and reports the suggested scalar-plus-slice construction.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.