rust-lang / rust-lang/rust-clippy
Add an internal lint for `check_create_post` and `span_lint`
Open
Nobody has claimed this yet.
A-lint
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
When linting through check_create_post, we must use span_lint_hir_and_then to respect the lint level attribute. We can have an internal clippy lint to be sure that all our lints do not fall into this trap.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked rust-clippy pull request and searching for check_create_post, span_lint, and span_lint_hir_and_then in the repository. Determine how an internal Clippy lint can detect the unsafe linting pattern and add the corresponding coverage; done means the internal lint catches uses that do not respect the lint level attribute.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100