rust-lang / rust-lang/rust-clippy

lint usage of struct constructors when new/from method is available

Open
#1,216 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint good first issue L-style T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

if a struct has a new or a from method that does the same as a struct constructor, then that method should be used instead of the struct constructor.

Obviously the usage of a struct constructor inside the new or from method should not be linted.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by surveying existing Rust Clippy lint implementations and their tests for struct-constructor or method-call patterns; the issue names no specific files. The work is complete when eligible struct-constructor uses are linted in favor of an equivalent new or from method, while constructor calls inside those methods are excluded.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.