rust-lang / rust-lang/rust-clippy
Lint Suboptimal Expression Order
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
(This one is nicked from fb-contrib). Lint expressions of the kind
(method)call &&/|| (no method call) {==, !=} (no method call)
e.g. potentially_expensive_check() && a == b
And suggest to reorder the subexpressions to possibly improve performance. Note that this may change behavior if potentially_expensive_check() has side effects.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating existing Clippy lint implementations and tests for expression-order checks. Review how the project handles method calls, boolean expressions, and side effects. Done means the described expression pattern is detected and a reorder suggestion is produced without overlooking the stated behavior caveat.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100