rust-lang / rust-lang/rust-clippy
New lint suggestion: Lint against `Some(self)` in `Error::source`
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
This lint prevents the incorrect usage of returning Some(self) in Error::source.
Advantage
- Avoid an infinite loop for consumers of
Error::sourcethat wants to visit all the error sources.
Drawbacks
No response
Example
impl Error for MyError {
fn source(&self) -> Option<&(dyn Error + 'static)> {
Some(self)
}
}
Could be written correctly as:
impl Error for MyError {}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation files or tests are named in the issue. Start by locating Clippy's existing lint implementations and tests for Rust error handling, then compare their structure with the Error::source example. Done means the incorrect Some(self) pattern is diagnosed by a lint and covered by tests without affecting valid implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100