rust-lang / rust-lang/rust-clippy
Lint repeating a `&'static str` a constant number of times
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Detect instances of &<string literal>.repeat(<integer literal (or maybe const?)>), which needlessly allocate a String.
Advantage
Removes an allocation
Drawbacks
Code might be less readable for large n.
Example
&"foo".repeat(5)
Could be written as:
"foofoofoofoofoo"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no implementation files or tests. Start by locating the relevant Clippy lint and its test conventions; done means detecting the shown repeated string-literal pattern and providing an equivalent literal without the unnecessary String allocation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100