rust-lang / rust-lang/rust-clippy

Lint useless shadowing

Open
#11,704 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Shadowing let x and then let mut x bindings with no intermediate uses of x could be combined to a single statement.

Advantage
  • Removes unneeded binding
  • Perhaps optimizes stores/loads if it happens across function boundaries/crates
  • Increases robustness of refactoring
Drawbacks

No response

Example

fn foo() -> i32 {
    let x = 6;
    let mut x = x;
    x += 1;
    x
}

Could be written as:

fn foo() -> i32 {
    let mut x = 6;
    x += 1;
    x
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating Clippy's existing lint implementation and test patterns for shadowing, then use the supplied Rust example to define the no-intermediate-use case and verify that the lint suggestion preserves behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.