rust-lang / rust-lang/rust-clippy

Reduce `match` guard with equality with straightforward `match`

Open
#11,697 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Prefer matching on the value directly instead of using a guard with equality

Advantage

No response

Drawbacks

No response

Example
match x {
    y if y == 100 => ...,
}

Could be written as:

match x {
    100 => ...,
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing Clippy's existing lint patterns for match guards and the Rust examples in this issue. The work is done when a guard comparing a matched value with equality is recognized as a direct value pattern, with coverage for the shown transformation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.