Clippy warns about or_insert_with usage in implementation of or_default

Summary

The imbl crate (https://github.com/jneem/imbl/tree/8756e765d8f76688da333b751db14287ae862c20) defines two Entry types at src/ord/map.rs and src/hash/map.rs with these methods:

/// Insert a default value if there was no value already, and
/// return a mutable reference to the value.
pub fn or_default(self) -> &'a mut V
where
    V: Default,
{
    self.or_insert_with(Default::default)
}

/// Get the key for this entry.
#[must_use]
pub fn key(&self) -> &K {
    match self {
        Entry::Occupied(entry) => entry.key(),
        Entry::Vacant(entry) => entry.key(),
    }
}

and clippy warns:

warning: use of `or_insert_with` to construct default value
    --> src/hash/map.rs:1419:14
     |
1419 |         self.or_insert_with(Default::default)
     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Applying this suggestions makes or_default recurse unconditionally (which clippy then also warns about, luckily).

Lint Name

unwrap_or_default

Reproducer

No response

Version

rustc 1.73.0-nightly (180dffba1 2023-08-14)
binary: rustc
commit-hash: 180dffba142c47240ca0d93096ce90b9fd97c8d7
commit-date: 2023-08-14
host: x86_64-unknown-linux-gnu
release: 1.73.0-nightly
LLVM version: 17.0.0

Additional Labels

No response

Reproduce the warning with the imbl implementations in src/ord/map.rs and src/hash/map.rs using the reported unwrap_or_default lint and Rust version. Check why the suggested or_default replacement recurses, then verify that the lint no longer produces an invalid suggestion or warning for these methods without regressing the intended lint behavior.