rust-lang / rust-lang/rust-clippy
Do not match constants or literals
Open
@Centri3 is already working on this.
Since Jul 24, 2023.
A-lint
L-suspicious
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Checks if you're using match against a constant or a literal.
Advantage
There is no need to perform a match against a constant.
Drawbacks
Maybe it would raise false positives for compile-time constants.
Example
const FOO: i32 = 3;
let bar = match FOO {
1 => "true",
_ => "false",
};
or:
let bar = match 3 {
1 => "true",
_ => "false",
};
Could be written as:
let bar = "true"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.