rust-lang / rust-lang/rust-clippy
Identical Or patterns
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
In pattern matching, if you write Pattern | Pattern => ... then it should suggest writing Pattern => .... Duplicating a pattern twice in an Or pattern is unnecessary.
Advantage
- Reduces the amount of code.
- In many cases will spot bugs, when the code was meant to be different.
Drawbacks
None I can think of.
Example
match x {
(Ty::Tuple(_), _) | (Ty::Tuple(_), _) => true,
_ => false,
}
Could be written as:
match x {
(Ty::Tuple(_), _) => true,
_ => false,
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides no source file or test entry point; begin by locating Clippy’s pattern-matching lint code and its regression tests. Use the supplied Rust match example as the starting case, and consider the work complete when identical alternatives in an Or pattern are diagnosed while the simplified form remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100