rust-lang / rust-lang/rust-clippy
Implicit Reborrowing lint
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Detects uses of &mut T values where implicit reborrowing happens. Suggests using &mut *.
Lint Name
implicit_reborrow
Category
restriction
Advantage
The very example used in this lint request is surprising. It produces different behaviour based on whether you have let y: &mut String or just let y.
Drawbacks
None known.
Example
let x = &mut String::new();
let y: &mut String = x;
y.push_str("Hello, ");
x.push_str("world!");
Could be written as:
let x = &mut String::new();
let y: &mut String = &mut *x;
y.push_str("Hello, ");
x.push_str("world!");
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the proposed implicit_reborrow lint but mentions no files, tests, or entry points. Start by reviewing how Clippy restriction lints are registered and tested; it is done when the shown implicit &mut T assignment is detected and the explicit &mut * form is accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100