rust-lang / rust-lang/rust-clippy
`bool_comparison` should not fire when testing for false
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I think that the bool_comparison lint should not fire when the comparison is var == false because, at least I, find that version much easier to see when quickly scrolling through the code than the !var as it is too simple to miss that single !.
However, I'm just putting this here for discussion I'll go turn the lint off in that specific place.
Enjoy your rusty endeavors.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the bool_comparison lint and its tests, then reproduce the behavior for comparisons with false. Confirm the desired change with the discussion before updating the lint and tests so that var == false is accepted while the intended lint behavior remains covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100