rust-lang / rust-lang/rust-clippy
Graduate manual_string_new to clippy::style
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
manual_string_new is a rule that standardizes how empty strings are created, which is not only a good style option (with no known false-positives in the docs), but also helps prevent against zero-width characters being submitted internally.
The Pull Request (#9366) that moved this to pedantic referred to it as:
- a fairly minor style change
- could be very noisy
However, not only are many existing non-pedantic style lints noisy (as they can appear a lot), but this one is also idiomatic and uses an in-built method to create an empty string.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the manual_string_new rule documentation linked in the issue and review Pull Request #9366 for the rationale behind its current classification. Confirm the implications of moving the rule to clippy::style; done means the classification is updated without changing the rule's behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100