rust-lang / rust-lang/rust-clippy
elide zero-check for integral dividend
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
elide check that compare to zero for integral dividend
Lint Name
zero_dividend_check
Category
suspicious
Advantage
- Remove redundancy
Drawbacks
- this may wrong if both operands are zero at runtime
Example
/* let rest = ...; */
/* let div_100 = ...; */
if rest == 0 {
0 // only zero
} else {
rest / div_100
};
Could be written as:
rest / div_100
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the proposed zero_dividend_check lint but does not identify implementation files or tests. Start by reading Clippy's contribution guidance and locating existing suspicious lints with similar arithmetic checks; done means the lint handles the shown integral-dividend case and has tests covering the stated zero-operand concern.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100