rust-lang / rust-lang/rust-clippy

Apply format lints to format-like macros from other crates (e.g. log::log!)

Open
#10,165 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Description

As these are similar things it would be nice if the same lints applied to both. The log crate actually uses format_args! internally but it seems the lints are only applied to the outermost macro invocation. So either that would need to be fixed or clippy would need to recognize the log crate specifically (and I don't see any prior art today for linting use of third-party APIs, even ones as common as log).

Version

No response

Additional Labels

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by tracing how Clippy applies format lints through macro invocations, then compare that behavior with log::log! and its internal format_args! use. Done means the same relevant format lints apply to supported format-like macros from other crates, or the chosen approach is documented by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.