rust-lang / rust-lang/rust-clippy

Detect named lifetimes that are effectively `'static`

Open
#10,108 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Given a function that returns a borrow to a lifetime that isn't used in any parameter, give and explanation and suggest removing the named lifetime and making it 'static, as it is the only effective lifetime that will work:

fn foo<'a>() -> &'a str { todo!() }
Lint Name

hidden_static_lifetime

Category

suspicious, style, pedantic

Advantage

It makes the code easier to follow and is a good thing to teach users about.

Drawbacks

No response

Example
fn foo<'a>() -> &'a str { todo!() }

Could be written as:

fn foo() -> &'static str { todo!() }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Rust playground example and the issue's hidden_static_lifetime lint name. Trace how Clippy defines and tests similar suspicious or style lints, then verify the implementation explains the ineffective named lifetime and suggests the shown 'static form.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.