rust-lang / rust-lang/rust-clippy

suboptimal_flops: can't call method `mul_add` on ambiguous numeric type `{float}

Open
#10,015 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug I-false-positive I-suggestion-causes-error
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Summary

.

Lint Name

suboptimal_flops

Reproducer

I tried this code:

pub fn main() {
    let pi = 3.1415927;
    println!("{:?}", -pi * (pi + 2.0 / pi) - pi * 5.0);
}

I saw this happen:

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we'd be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag

The following errors were reported:
error[E0689]: can't call method `mul_add` on ambiguous numeric type `{float}`
 --> src/main.rs:3:28
  |
3 |     println!("{:?}", (-pi).mul_add(pi + 2.0 / pi, -pi * 5.0));
  |                            ^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0689`.
Original diagnostics will follow.

warning: multiply and add expressions can be calculated more efficiently and accurately
 --> src/main.rs:3:22
  |
3 |     println!("{:?}", -pi * (pi + 2.0 / pi) - pi * 5.0);
  |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `(-pi).mul_add(pi + 2.0 / pi, -pi * 5.0)`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suboptimal_flops
  = note: requested on the command line with `-W clippy::suboptimal-flops`
Version
rustc 1.67.0-nightly (c97b539e4 2022-11-30)
binary: rustc
commit-hash: c97b539e408ea353f4fde2f9251d598291fec421
commit-date: 2022-11-30
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4
Additional Labels

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported suboptimal_flops case with the Rust code and nightly version shown above, then inspect the lint's implementation and existing tests. The issue is resolved when the lint no longer suggests a mul_add call that fails with ambiguous {float} inference, while valid suggestions continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.