rust-lang / rust-lang/rust-by-example

If and how to PR a great deal of changes

Open
#1,817 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion enhancement
Dominant language
Handlebars
Stars
8.1k
Forks
1.6k
PR merge metrics
No merged PRs in 30d

Description

I ended up reviewing most of this book, and have come to the conclusion that the book needs a non-trivial number of changes to bring it more up-to-date and to correct some inaccuracies.

You can read my notes here.

If you (the maintainers) wish, I can see about turning my notes into PRs. But as you can see, there are a lot of notes. My questions are

  1. Would this be productive -- can you entertain a large number of changes?
  2. If so, how best should the PRs be made -- per page, per chapter?
  3. Is it okay restructure sections/pages or are you trying to maintain the page names, etc?

Alternatively, feel free to make use of the notes without my further involvement.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked rbe-notes README.md and the issue discussion about handling the proposed changes. Done means the maintainers have agreed whether to accept the updates and how to divide them into pull requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.