rust-lang / rust-lang/rust-bindgen

0.73 and doc tests

Open
#3,492 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5.3k
Forks
829
Avg merge
1d 1h
Merged PRs (30d)
15

Description

There seems to be something wrong with bindgen version 0.73 and cargo test --doc.
See https://github.com/rusqlite/rusqlite/pull/1902
And https://github.com/rusqlite/rusqlite/actions/runs/34806322628/job/103858795372?pr=1902
I managed to reproduce locally with

diff --git a/libsqlite3-sys/Cargo.toml b/libsqlite3-sys/Cargo.toml
index d14cd37..99f5218 100644
--- a/libsqlite3-sys/Cargo.toml
+++ b/libsqlite3-sys/Cargo.toml
@@ -50,7 +50,7 @@ wasm32-wasi-vfs = []
 openssl-sys = { version = "0.9.103", optional = true }

 [build-dependencies]
-bindgen = { version = "0.72", optional = true, default-features = false, features = [
+bindgen = { version = "0.73", optional = true, default-features = false, features = [
     "runtime",
 ] }
 pkg-config = { version = "0.3.19", optional = true }

And

rusqlite % cargo test --features 'buildtime_bindgen' --doc --workspace

Regards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked rusqlite pull request and CI job, then reproduce the failure using cargo test --features 'buildtime_bindgen' --doc --workspace after changing libsqlite3-sys/Cargo.toml from bindgen 0.72 to 0.73. The issue does not identify a bindgen source file or expected fix; done means determining the regression and restoring passing workspace documentation tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.