rust-lang / rust-lang/rust-bindgen

macros defining integer constants using expressions containing enum values don't work

Open
#258 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-libclang A-macros
Dominant language
Rust
Stars
5.3k
Forks
829
Avg merge
1d 1h
Merged PRs (30d)
15

Description

In Gecko (in gfxFontConstants.h) we have:

enum {
    eFeatureAlternates_historical,
    eFeatureAlternates_stylistic,
    eFeatureAlternates_styleset,
    eFeatureAlternates_character_variant,
    eFeatureAlternates_swash,
    eFeatureAlternates_ornaments,
    eFeatureAlternates_annotation,

    eFeatureAlternates_numFeatures
};

#define NS_FONT_VARIANT_ALTERNATES_HISTORICAL        (1 << eFeatureAlternates_historical)

rust-bindgen doesn't generate anything for NS_FONT_VARIANT_ALTERNATES_HISTORICAL.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the macro and enum example from gfxFontConstants.h and reproduce the missing NS_FONT_VARIANT_ALTERNATES_HISTORICAL binding in rust-bindgen. Trace how macro expressions containing enum values are handled; done means bindgen emits a usable Rust constant for this expression.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.