rust-lang / rust-lang/rust-bindgen

Binding for const <typedef-ed array type> has incorrect mutability

Open
#1,962 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5.3k
Forks
829
Avg merge
1d 1h
Merged PRs (30d)
15

Description

Input C/C++ Header
typedef int int1[1];
void f(const int1 x);
Bindgen Invocation
$ bindgen test.h
Actual Results
/* automatically generated by rust-bindgen 0.56.0 */

pub type int1 = [::std::os::raw::c_int; 1usize];
extern "C" {
    pub fn f(x: *mut ::std::os::raw::c_int);
}
Expected Results

The type of the parameter x should be *const ::std::os::raw::c_int:

/* automatically generated by rust-bindgen 0.56.0 */

pub type int1 = [::std::os::raw::c_int; 1usize];
extern "C" {
    pub fn f(x: *const ::std::os::raw::c_int);
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided test.h header and the bindgen test.h invocation. Trace how const is handled for a const typedef-ed array parameter, then verify that the generated declaration uses *const rather than *mut and add a regression check for the shown input.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.