rust-lang / rust-lang/rust-bindgen
bindgen shouldn't generate f32 for c floats
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 5.3k
- Forks
- 829
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 15
Description
According to the conversation in https://github.com/gnzlbg/ctest/pull/69#issuecomment-496576037, the fact that bindgen switched from generating c_float to f32 is a bug. I've encountered this in the harfbuzz bindings via https://github.com/servo/rust-harfbuzz/blob/d782b2c021978c615b870588555df80996dd39f7/harfbuzz-sys/harfbuzz/src/hb-font.h#L692.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the linked ctest pull request conversation first, then inspect the harfbuzz header at harfbuzz/src/hb-font.h around line 692. Trace bindgen's generated type for the C float declaration and compare it with the reported harfbuzz bindings. Done means C float declarations generate c_float rather than f32.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100