rust-lang / rust-lang/rust-bindgen
--target flag addition in BindgenContext could cause issues.
Open
Nobody has claimed this yet.
bug
I-unclear
- Dominant language
- Rust
- Stars
- 5.3k
- Forks
- 829
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 15
Description
13:19 <glandium> emilio: note, there might be something fishy with the automatic addition of --target in BindgenContext, too
13:19 <glandium> emilio: because that doesn't take into account flags like -m32/-m64
13:22 <glandium> it's probably not doing any harm in firefox, but I can see how it could break things in the general case
13:27 <emilio> glandium: https://github.com/rust-lang/rust-bindgen/pull/1543 for the --target stuff
13:27 <emilio> glandium: will file an issue for -m32 / -m64
```Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating BindgenContext and the code that automatically adds --target. Trace how existing compiler flags, especially -m32 and -m64, are collected and passed, then inspect any related tests. Done means the target selection no longer conflicts with those flags and coverage demonstrates the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100