rust-lang / rust-lang/rust-analyzer
Extract to function doesn't account for lifetimes
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
I was using the extract to function "quick-fix" and it works great, but, doesn't account for lifetimes. I have a struct that needs the 'static lifetime, and I have a function that returns a Vec of this struct with the lifetime. Rust-Analyzer doesn't add in the lifetime. It should look like:
-> Vec<Recipe<'static>> but in reality it looks like -> Vec<Recipe>
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the extract-to-function quick-fix and reproduce the reported case using a struct requiring a 'static lifetime and a function returning Vec. Check how the generated return type handles lifetimes; done means it preserves the required Vec<Recipe<'static>> annotation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100