rust-lang / rust-lang/rust-analyzer

Code action suggestion: add / remove braces of closure

Open
#8,272 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists S-actionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

It would be nice if there is a code action which removes or adds curly braces of the closure. i.e.

  vec.iter().filter(|x| x % 2 == 0)

becomes

  vec.iter().filter(|x| {
    x % 2 == 0
  })

or vice versa.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating rust-analyzer's code-action entry points and the closure syntax handling related to the examples in this issue. Check existing code-action tests before defining coverage for adding and removing braces, and consider the work done when both transformations are offered correctly for applicable closures.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.