rust-lang / rust-lang/rust-analyzer
hir::*::module doesn't make sense
Open
Nobody has claimed this yet.
C-Architecture
S-unactionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Many hir types have ::module method, but this is wrong, as this can't have reasonable semantics: items can be nested. So we should remove all those module calls and replace them with something which makes sense. Super unclear what that should be.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating all hir::*::module methods and their call sites. The issue does not identify files, tests, or a replacement API, so first determine how nested items should be represented and confirm the intended semantics with maintainers. Done means every unsuitable module call is replaced with an agreed alternative and the affected tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100