rust-lang / rust-lang/rust-analyzer
Import/Qualify assist doesn't apply for traits/types if shadowed by macros or values
Open
Nobody has claimed this yet.
A-ide
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
The Hash derive macro is in scope due to the implicit prelude, so to RA Hash resolves here and therefor we don't get the option to import the trait here.
This happens in general when another kind of namespace(Value or Macro) shadows a type or trait.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the example shown in the issue and trace the Import/Qualify assist through rust-analyzer's name-resolution logic. Check how type and trait candidates are handled when a macro or value shadows them. Done means the assist offers the expected import despite the shadowing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100