rust-lang / rust-lang/rust-analyzer

Renaming a struct field should rename variables that destructure the field

Open
#6,547 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature S-actionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

The title is not as clear as it could be - here's an example:

        let Item { attrs, name, source, visibility, def_id, inner, stability, deprecation } = item;

When I rename inner to kind, I expect this to be changed to

        let Item { attrs, name, source, visibility, def_id, kind, stability, deprecation } = item;

and all usages of inner in this scope updated. Instead, rust-analyzer changes it to

        let Item { attrs, name, source, visibility, def_id, kind: inner, stability, deprecation } = item;

which is not super helpful and messes up rustfmt.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the rename using the Rust destructuring example in the issue and inspect rust-analyzer's rename behavior for the field and its local uses. The work is done when renaming inner to kind produces a shorthand kind binding, updates usages in scope, and no longer leaves the kind: inner form that upsets rustfmt.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.