rust-lang / rust-lang/rust-analyzer
Renaming a struct field should rename variables that destructure the field
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
The title is not as clear as it could be - here's an example:
let Item { attrs, name, source, visibility, def_id, inner, stability, deprecation } = item;
When I rename inner to kind, I expect this to be changed to
let Item { attrs, name, source, visibility, def_id, kind, stability, deprecation } = item;
and all usages of inner in this scope updated. Instead, rust-analyzer changes it to
let Item { attrs, name, source, visibility, def_id, kind: inner, stability, deprecation } = item;
which is not super helpful and messes up rustfmt.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the rename using the Rust destructuring example in the issue and inspect rust-analyzer's rename behavior for the field and its local uses. The work is done when renaming inner to kind produces a shorthand kind binding, updates usages in scope, and no longer leaves the kind: inner form that upsets rustfmt.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100