rust-lang / rust-lang/rust-analyzer
LSP: Validate Edits against document versions
Open
Nobody has claimed this yet.
A-lsp
C-enhancement
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
We should validate that any edits returned from the server can be applied to the requested document version. For instance this should happen at prepare rename, rename, code actions etc. If the version check is failed we should return an error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the LSP paths that produce edits for prepare rename, rename, and code actions, then inspect how requested document versions are represented. Done means edits for a mismatched document version are rejected with an error across the listed operations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100