rust-lang / rust-lang/rust-analyzer

[Semantic Highlighting] Consuming modifier should apply to other cases

Open
#5,856 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-highlighting E-hard S-unactionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

At the moment it only seems to apply to the self argument of method calls. However the other arguments of the call may be consumed as well. Additionally cases like let y = x; should probably be covered too.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing semantic highlighting for method calls where arguments are consumed, then compare it with a binding such as let y = x;. Trace the existing handling of the consuming modifier and identify the relevant semantic-highlighting entry point. Done means consuming highlighting also covers other consumed call arguments and these binding cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.