rust-lang / rust-lang/rust-analyzer
Renaming use alias renames the aliased symbol instead
Open
Nobody has claimed this yet.
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
I'd expect that renaming the alias would rename the alias itself, but not the underlying symbol (especially if the underlying symbol comes from std or some other crate):
Code to play with:
mod foo {
pub(crate) fn bar() {}
}
use foo::bar as baz;
pub fn run() {
baz();
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Rust reproduction in the issue and inspect the rename behavior for use foo::bar as baz. The fix is done when renaming baz changes only the alias and leaves foo::bar unchanged, including when the underlying symbol comes from another crate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100