rust-lang / rust-lang/rust-analyzer
CodeAction fixes should be assigned the appropriate diagnostics
Open
Nobody has claimed this yet.
A-lsp
C-enhancement
E-unknown
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
CodeAction has a diagnostics field that our lsp_ext::CodeAction does not have. We should fill this in if an action fixes a diagnostic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the lsp_ext::CodeAction definition and the code that constructs CodeAction results. Trace how an action can be associated with a diagnostic, then populate the diagnostics field when it fixes one. Done means returned code actions expose the appropriate diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100