rust-lang / rust-lang/rust-analyzer
vscode middleware does not pass all the attributes through
Open
Nobody has claimed this yet.
A-assists
A-vscode
C-enhancement
E-has-instructions
E-medium
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Found while working on #5116
We do not everything on to vscode (isPreferred, diagnostics etc.)
https://github.com/rust-lang/rust-analyzer/blob/f1b257f4eb4fef74b42fd7135d1cf3884e8b51c9/editors/code/src/client.ts#L234
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in editors/code/src/client.ts at the linked line and inspect how middleware attributes are passed to VS Code. Compare the forwarded attributes with the available values, including isPreferred and diagnostics. Done means the missing attributes are passed through to VS Code without being dropped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100