rust-lang / rust-lang/rust-analyzer
StructuralSearchReplace: next steps
Open
Nobody has claimed this yet.
A-ide
E-hard
fun
good first issue
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
https://github.com/rust-analyzer/rust-analyzer/pull/3099 implemented initial version of SSR.
This issue collects things we need to do to make this really production-read
- add docs to https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/user/features.md
- improve matching code to handle trivia
- improve matching code to handle semantically equivalent transformations (for example, the order of the fields)
- add support for matchers other than
$expr
@mikhail-m1 any other things I've missed?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the initial SSR implementation in pull request 3099 and its matching-code section, then review the existing feature entry in docs/user/features.md. The work is complete when matching handles semantically equivalent transformations such as reordered fields and supports matchers beyond $expr.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100