rust-lang / rust-lang/rust-analyzer

Do not add parentheses when completing functions in closures without parameters

Open
#3,148 1 comment 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-completion S-actionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

fn multiply_by_2(input: u32) -> u32 {
    input * 2
}

fn main() {
    let initial = Some(22);
    let multiplied = initial.map(mul<|>);
}

Do a completion.

Expected:

fn multiply_by_2(input: u32) -> u32 {
    input * 2
}

fn main() {
    let initial = Some(22);
    let multiplied = initial.map(multiply_by_2<|>);
}

Actual:

fn multiply_by_2(input: u32) -> u32 {
    input * 2
}

fn main() {
    let initial = Some(22);
    let multiplied = initial.map(multiply_by_2(<|>));
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the completion in rust-analyzer using the Rust example from the issue, then trace the function-completion path for a closure without parameters. Done means completion inserts multiply_by_2<|> rather than multiply_by_2(<|>) in this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.