rust-lang / rust-lang/rust-analyzer
Incorrect rename edits outside of the workspace
Open
Nobody has claimed this yet.
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: rust-analyzer 0.4.3037-standalone
rustc version: rustc 1.100.0-nightly (c54751567 2026-08-22)
editor or extension: Vim coc-rust-analyzer
code snippet to reproduce:
pub struct r#pub;
When I try to apply the Rename to R#pub in #23304:
{
"documentChanges": [],
"changeAnnotations": {
"OutsideWorkspace": {
"label": "Edit outside of the workspace",
"needsConfirmation": true,
"description": "This edit lies outside of the workspace and may affect dependencies"
}
}
}
crates/rust-analyzer/src/lsp/to_proto.rs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in crates/rust-analyzer/src/lsp/to_proto.rs and reproduce the rename for pub struct r#pub; using the reported Vim coc-rust-analyzer setup. Inspect the generated workspace edit and its change annotations. Done means the rename no longer reports an incorrect edit outside the workspace for this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100