rust-lang / rust-lang/rust-analyzer
Offer to replace ref pattern with matching on a reference
Open
Nobody has claimed this yet.
A-assists
C-feature
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
An assist to turn things like
match foo {
Some(ref x) => {}
None => {}
}
and
if let Some(ref x) = foo {
}
into
match &foo {
Some(x) => {}
None => {}
}
and
if let Some(x) = &foo {
}
(i.e. make use "match ergonomics") would be very appreciated :)
@rustbot label +A-assists
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the existing assist implementation for Rust patterns and its tests; the issue does not name specific files or entry points. Check how assists are registered and tested, then verify that the ref-pattern examples are transformed to equivalent match-ergonomics forms without changing other patterns.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100