rust-lang / rust-lang/rust-analyzer

Add an action to convert structure update syntax to explicit field passing

Open
#21,736 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

i.e. consider this:

fn f() {
    struct S { a: u8, b: u8, c: u8 }

    let s = S { a: 0, b: 1, c: 2 };
    let s = S { b: 4, ..s };
    //                ^^^ cursor somewhere here
}

==>>

fn f() {
    struct S { a: u8, b: u8, c: u8 }

    let s = S { a: 0, b: 1, c: 2 };
    let s = S { b: 4, a: s.a, c: s.c };
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides a Rust example of the desired structure-update conversion but names no files, tests, or entry points. Start by locating rust-analyzer's existing assist/action infrastructure for structure expressions and inspect similar transformations. Done means the action expands ..s into explicit field assignments while preserving explicitly supplied fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.